Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ARM modules #613

Merged
merged 42 commits into from
Jul 13, 2021
Merged

adding ARM modules #613

merged 42 commits into from
Jul 13, 2021

Conversation

krnese
Copy link
Contributor

@krnese krnese commented Jun 9, 2021

This PR fixes

  • Re-structuring the ARM templates for all resource deployments
  • eslzArm.json is used to orchestrate the e2e composition of ESLZ, and subsequent resource deployments based on user input from portal experience
  • The composite ARM templates can be sequenced on their own, independently of each other (although strict sequencing is required to ensure the same outcome)
  • Customers can deploy from private repository if they want to sequence at their own pace
  • Converging Contoso, AdventureWorks, and Wingtip into one ESLZ deployment experience via first-party deployment in Azure portal
  • Removing individual policy assignment for Azure Monitor for VMs, and are now using the built-in policy initiative to achieve the same which spans Windows, Linux (VM and VMSS), as well as Azure Arc enabled VMs.
  • Deploy Log Analytics DINE policy has moved to built-in, hence removing the custom policy from ESLZ and use built-in for assignment at the management management group
  • Support N network topologies in same experience (hub and spoke, vwan, hub and spoke with NVA)
  • Optimizing the execution graph
  • Added option for peering virtual network in identity subscription (nva, hub and spoke, and vwan)
  • Added option for peering landing zones to connectivity subscription when hub & spoke is the selected topology (VWAN is excluded due to concurrency issues)
  • Navigate policy assignment for identity, when using single vs dedicated subscriptions for platform purposes
  • Moving several of the diagnostics policies to built-in, and updating the diagnostics initiative (this means there's a new resource name as update of existing one will not be allowed due to removal of parameters)
  • Adding policy initiative for denying public endpoints (using built-ins)
  • Adding policy initiative for enforcing private dns zone association with private link (using built-ins)
  • Updated description and display name for all policy assignments

@krnese krnese linked an issue Jun 9, 2021 that may be closed by this pull request
@krnese krnese marked this pull request as ready for review July 9, 2021 17:25
@krnese krnese added documentation Improvements or additions to documentation enhancement New feature or request policy labels Jul 12, 2021
@krnese krnese linked an issue Jul 13, 2021 that may be closed by this pull request
Copy link
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic improvements! Looks good to me.

@krnese krnese merged commit e411a85 into Azure:main Jul 13, 2021
@krnese krnese deleted the arm-modules branch July 13, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request policy
Projects
None yet
2 participants