Workflow OIDC Update #1675
Merged
Workflow OIDC Update #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Springstone
added
the
PR: Safe to test 🧪
matt-FFFFFF
approved these changes
Jun 14, 2024
matt-FFFFFF
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This pull request includes a significant change to the Azure login process in the
.github/workflows/test-portal.ymlfile. The change simplifies the login process by upgrading the Azure login action to version 2 and removing the distinction between OIDC and Client Secret logins..github/workflows/test-portal.yml: Upgraded the Azure login action from version 1 to version 2, removing the need for separate OIDC and Client Secret login steps. This simplifies the login process and makes the workflow more maintainable.As part of this PR, we also need to cleanup AZURE_CLIENT_SECRET.