Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel Deployment Fix #1709

Merged
merged 16 commits into from
Aug 14, 2024
Merged

Sentinel Deployment Fix #1709

merged 16 commits into from
Aug 14, 2024

Conversation

Springstone
Copy link
Member

Overview/Summary

This pull request contains changes to the eslzArm/eslzArm.json and eslzArm/subscriptionTemplates/logAnalyticsWorkspace.json files. The changes mainly revolve around the removal of the enableSecuritySolution parameter and related deployment references. Additionally, there is an update to the API version in the logAnalyticsWorkspace.json file.

Removal of enableSecuritySolution:

Removal of logAnalyticsSolutions.json:

API version update:

Testing URLs

Azure Public

Deploy To Azure

@Springstone Springstone requested a review from a team as a code owner July 18, 2024 13:19
@Springstone Springstone added the PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments label Jul 18, 2024
@Springstone Springstone requested a review from jtracey93 July 18, 2024 13:46
@jtracey93
Copy link
Collaborator

@arjenhuitema can you confirm none of the solutions for LAW are needed anymore?

@Springstone
Copy link
Member Author

@arjenhuitema can you confirm none of the solutions for LAW are needed anymore?

None are currently used. Everything was commented out except the old way of deploying Sentinel.

@arjenhuitema
Copy link
Contributor

@arjenhuitema can you confirm none of the solutions for LAW are needed anymore?

Correct, there is no need to deploy any of the legacy solutions anymore. Sentinel was the last one.

Note that the ChangeTracking solution is still installed but this is done automatically as part of the CT DCR deployment.

@jtracey93 jtracey93 closed this Aug 14, 2024
@jtracey93 jtracey93 reopened this Aug 14, 2024
@jtracey93 jtracey93 added Type: Enhancement ✨ New feature or request Status: Do Not Merge ⛔ Do not merge PRs with this label attached as they are not ready etc. labels Aug 14, 2024
@jtracey93 jtracey93 removed the Status: Do Not Merge ⛔ Do not merge PRs with this label attached as they are not ready etc. label Aug 14, 2024
@jtracey93 jtracey93 merged commit 24ae46a into Azure:main Aug 14, 2024
3 of 4 checks passed
@Springstone Springstone deleted the Sentinel branch August 14, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Safe to test 🧪 PRs can run more advanced tests that may deploy or access environments Type: Enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants