review feedback

Azure · Jul 28, 2023 · 1d00e13 · 1d00e13
1 parent aa6ff62
commit 1d00e13
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/tests_e2e/tests/lib/remote_test.py b/tests_e2e/tests/lib/remote_test.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python3
+#!/usr/bin/env pypy3
 
 # Microsoft Azure Linux Agent
 #
@@ -28,14 +28,19 @@
 
 
 def run_remote_test(test_method: Callable[[], int]) -> None:
+    """
+    Helper function to run a remote test; implements coding conventions for remote tests, e.g. error message goes
+    to stderr, test log goes to stdout, etc.
+    """
     try:
         test_method()
-        log.error("*** PASSED")
+        log.info("*** PASSED")
     except AssertionError as e:
         print(f"{e}", file=sys.stderr)
         log.error("%s", e)
         sys.exit(FAIL_EXIT_CODE)
     except Exception as e:
+        print(f"UNEXPECTED ERROR: {e}", file=sys.stderr)
         log.exception("*** UNEXPECTED ERROR")
         sys.exit(ERROR_EXIT_CODE)
 

diff --git a/tests_e2e/tests/scripts/samples-pass_remote_test.py b/tests_e2e/tests/scripts/samples-pass_remote_test.py
@@ -18,7 +18,7 @@
 #
 
 #
-# A sample remote test that simulates an unexpected error
+# A sample remote test that passes
 #
 
 from tests_e2e.tests.lib.logging import log