2.1 scvmm detection and support broken

[emsi]

It seems scvmm detection and integration is completely broken now.
Daemon calls for:

        if conf.get_detect_scvmm_env():
            if self.distro.scvmm_handler.run():
                return

While ScvmmHandler class does not have method run() at all.
When I corrected for that I got error:
UbuntuOSUtil object has no attribute 'get_dvd_mount_point'

[emsi]

When I dug it even deeper I found that the waagent is trying to mount /dev/sr1 while LinuxAgent.iso is exposed via /dev/sr0 under scvmm.
I did all the tests on Ubuntu 16.04 (though it was already broken on 15.10). The 14.04 worked like charm though it used waagent 2.0.

[ahmetb]

@emsi what is the exact waagent version you have?

[emsi]

@ahmetalpbalkan The one shipped with Ubuntu cloud images: 2.1.3
BTW: the problematic code looks the same on the GitHub branch 2.1 (even tag v2.1.4)

[emsi]

@hglkrijger Your patch addresses only the half of the issue.
The problem is that distro.osutil.mount_dvd() is trying to mount the wrong DVD. When the image is provisioned the scvmm is adding dedicated DVD with configuration however mount_dvd() is trying to mount the /dev/sr1 (the logic in get_mount_mount() returns the first match which is sr1 in this case rather than sr0).

[hglkrijger]

Thanks for the feedback @emsi; I should have waited until the complete fix was ready before pushing to my fork, apologies for the confusion.

I believe the issue is addressed now, pending testing - see this commit. Feel free to take a look and let me know if you have any concerns.

/cc @szarkos

[hglkrijger]

the agent itself should be fixed with #219. we need to make sure the SCVMM install script is updated to support systemd, or the provisioning will loop.

[hglkrijger]

closing this, further issues with scvmm itself should be tracked at https://github.com/Microsoft/SCVMMLinuxGuestAgent

[emsi]

The SCVMMLinuxGuestAgent project on github seems dead. No activity for two years. When I build the sources it produced scvmmguestagent.1.0.2.1065.x64.tar whereas the SCVMM is distributed with scvmmguestagent.1.0.2.1075.x86.tar.
Do you know if there's any way I can contact the product team?

[brendandixon]

@emsi I have no idea. The existing agent has basic support for SCVMM, so I don't believe that an additional agent is necessary.

[emsi]

It's not. It just that the current one does not work properly with systemd.

[brendandixon]

@emsi We do not own the systemd unit. Those come from the distribution vendors.

[emsi]

I have no idea why do you think there's anything wrong with the systemd unit.
I just asked about the contact to Microsoft product team that is responsible for SCVMMLinuxGuestAgent because the project page on the github is dead and holds the old version of agent.

[brendandixon]

@emsi I was, I thought, responding to your comment that the current agent does not work with systemd.

Regardless, the existing agent has SCVMM support and is where we devote our efforts. If you have a specific bug, please file an issue with sufficient details so we can address it.

[emsi]

Oh boy :) You misunderstood me completely.
When we fixed some issues with WALinuxAgent SCVMMAget interoperability the only problem left is with SCVMMagent. @hglkrijger redirected me to SCVMMAgent guthub project which seems pretty dead (I outlined my reasons why I think so). Since you all appear to me as Microsoft azure members I kindly asked if you have any means of contact to SCVMM agent product team.

[brendandixon]

@emsi Mea Culpa! I can try. Take care.

[emsi]

Thank you :)

[emsi]

@brendandixon: Any luck with that?