Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process a given GoalState just once #474

Closed
brendandixon opened this issue Oct 31, 2016 · 2 comments
Closed

Process a given GoalState just once #474

brendandixon opened this issue Oct 31, 2016 · 2 comments
Assignees
@jinhyunr
Labels
bug
Milestone
v2.2.2

Comments

@brendandixon
Copy link
Contributor

The code in exthandlers.py#run notes that latest processed GoalState in self.last_etag, however it never checks the value before processing the GoalState. This can cause unnecessary work and redundant messages in the log files.
@brendandixon brendandixon added this to the v2.2.1 milestone Oct 31, 2016
@jinhyunr jinhyunr self-assigned this Nov 7, 2016
@jinhyunr
Copy link
Contributor

jinhyunr commented Nov 8, 2016

Talked with Brendan and went trough the code offline. WALA is not processing GoalState when etag is not updated yet prints out excessive logs. Thus lowering the log level.

jinhyunr added a commit to jinhyunr/WALinuxAgent that referenced this issue Nov 8, 2016
@jinhyunr
Reduce the logging level to verbose when GoalState is not being proce…
4c66cbf 
…ssed (Azure#474)
hglkrijger pushed a commit that referenced this issue Nov 18, 2016
@jinhyunr @hglkrijger
Reduce the logging level to verbose when GoalState is not being proce…
80eeef5 
…ssed (#474) (#483)
@hglkrijger
Copy link
Member

fixed with #483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinhyunr jinhyunr

Labels
bug
Projects
None yet
Milestone
v2.2.2
Development

No branches or pull requests
3 participants
@brendandixon @jinhyunr @hglkrijger