Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust http retry and logging #784

Closed
hglkrijger opened this issue Jun 22, 2017 · 1 comment
Closed

Adjust http retry and logging #784

hglkrijger opened this issue Jun 22, 2017 · 1 comment
Milestone
2.2.15

Comments

@hglkrijger
Copy link
Member

The retry logic in restutil#http_request incorrectly adjusts max_retry which does not actually affect the retry loop, and has the side effect of disabling logging on subsequent http errors.

We should decide on the appropriate behavior here and fix accordingly.
@brendandixon brendandixon added this to the 2.2.15 milestone Jun 26, 2017
@brendandixon brendandixon mentioned this issue Aug 9, 2017
Merged
brendandixon added a commit that referenced this issue Aug 11, 2017
@brendandixon
Merge pull request #837 from brendandixon/master
0038baf 
[#823] -- Show config options in use
[#784] -- Adjust http retry and logging
@brendandixon
Copy link
Contributor

Addressed by #837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.15
Development

No branches or pull requests
2 participants
@brendandixon @hglkrijger