Add __main__ module to Python's egg #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonzio
reviewed
Dec 11, 2018
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| # Requires Python 2.6+ and Openssl 1.0+ |
There was a problem hiding this comment.
Didn't the agent step up to requiring Python 2.7?
There was a problem hiding this comment.
Not sure about that... same comment in all source files (main.py was an existing file) and Travis tests 2.6 (and 2.7).
There was a problem hiding this comment.
I ran into some issues with Python 2.6 and disabled it in my CI update PR. At this point 2.6 probably isn't worth maintaining anyway. Note every python file has a comment about 2.6 in it, which should be removed.
|
@vrdmr - Thanks for the review... I will hold on until I can test the change with DCR. Do not merge yet. |
|
DCR completed successfully. I{ll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main module (removed in a85e6cd) needs to be added to the Python's egg.
Issue #
PR information
Quality of Code and Contribution Guidelines