Do not report restart_if warnings as errors #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1498 +/- ##
========================================
Coverage 60.82% 60.82%
========================================
Files 75 75
Lines 10878 10878
Branches 1559 1559
========================================
Hits 6617 6617
Misses 3946 3946
Partials 315 315
Continue to review full report at Codecov.
|
pgombar
approved these changes
Mar 28, 2019
| @@ -1116,7 +1116,7 @@ def set_dhcp_hostname(self, hostname): | |||
| def restart_if(self, ifname, retries=3, wait=5): | |||
| retry_limit=retries+1 | |||
| for attempt in range(1, retry_limit): | |||
| return_code=shellutil.run("ifdown {0} && ifup {0}".format(ifname)) | |||
| return_code=shellutil.run("ifdown {0} && ifup {0}".format(ifname), expected_errors=[1] if attempt < retries else []) | |||
There was a problem hiding this comment.
nit: add spacing around return_code=shellutil.run(...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermittent failures resetting the network interface show routinely in automation runs.
shellutil.run always logs command failures as ERROR, when a failure of this specific command should be a warning (unless the number of retries is exceeded).
PR information
Quality of Code and Contribution Guidelines