Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for sending wrong header to HostGA /extensionManifest calls #1510

Merged
merged 8 commits into from
Apr 18, 2019

Conversation

larohra
Copy link
Contributor

@larohra larohra commented Apr 18, 2019

Description

This PR is to fix the bug where we don't send the correct headers for /extensionArtifacts calls made to HostGA.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #1510 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1510   +/-   ##
========================================
  Coverage    60.88%   60.88%           
========================================
  Files           75       75           
  Lines        10882    10882           
  Branches      1560     1560           
========================================
  Hits          6625     6625           
  Misses        3942     3942           
  Partials       315      315
Impacted Files Coverage Δ
azurelinuxagent/common/protocol/wire.py 69.12% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc43ce...840c0ba. Read the comment docs.

tests/protocol/test_wire.py Outdated Show resolved Hide resolved
tests/protocol/test_wire.py Outdated Show resolved Hide resolved
tests/protocol/test_wire.py Outdated Show resolved Hide resolved
tests/protocol/test_wire.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @narrieta and @pgombar)


tests/protocol/test_wire.py, line 405 at r2 (raw file):

call to client.fetch_
Sounds fair, will make the changes


tests/protocol/test_wire.py, line 424 at r2 (raw file):

Previously, narrieta (Norberto Arrieta) wrote…

can we add a little more detail to the comments? thanks

Will do, thanks!


tests/protocol/test_wire.py, line 426 at r2 (raw file):

Previously, narrieta (Norberto Arrieta) wrote…

let's move the call to client.fetch_manifest out of the assert to make it clear who we are testing (AAA unit test pattern). thanks

Done

Copy link
Contributor

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, LGTM!

Copy link
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants