-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for sending wrong header to HostGA /extensionManifest calls #1510
Conversation
…s - when it was downloaded directly or through HostGA
Codecov Report
@@ Coverage Diff @@
## develop #1510 +/- ##
========================================
Coverage 60.88% 60.88%
========================================
Files 75 75
Lines 10882 10882
Branches 1560 1560
========================================
Hits 6625 6625
Misses 3942 3942
Partials 315 315
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @narrieta and @pgombar)
tests/protocol/test_wire.py, line 405 at r2 (raw file):
call to client.fetch_
Sounds fair, will make the changes
tests/protocol/test_wire.py, line 424 at r2 (raw file):
Previously, narrieta (Norberto Arrieta) wrote…
can we add a little more detail to the comments? thanks
Will do, thanks!
tests/protocol/test_wire.py, line 426 at r2 (raw file):
Previously, narrieta (Norberto Arrieta) wrote…
let's move the call to client.fetch_manifest out of the assert to make it clear who we are testing (AAA unit test pattern). thanks
Done
…de; Also modified test to follow AAA pattern for unit-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the update, LGTM
Description
This PR is to fix the bug where we don't send the correct headers for /extensionArtifacts calls made to HostGA.
PR information
Quality of Code and Contribution Guidelines
This change is