-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preventing incorrect metrics to be sent on telemetry #1553
Conversation
Exposed the cgroups.collect exceptions to distinguish difference between incorrect configuration and 0 value.
9a62376
to
52a5994
Compare
Codecov Report
@@ Coverage Diff @@
## cgroups #1553 +/- ##
===========================================
+ Coverage 63.18% 63.22% +0.04%
===========================================
Files 78 78
Lines 10989 11029 +40
Branches 1543 1550 +7
===========================================
+ Hits 6943 6973 +30
- Misses 3710 3718 +8
- Partials 336 338 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be LGTM after refactoring the periodic_*
functions and adding more info to log messages, as Norberto commented.
5e40f6b
to
aae9fc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Description
Issue #
PR information
Quality of Code and Contribution Guidelines
This change is