Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing incorrect metrics to be sent on telemetry #1553

Merged
merged 7 commits into from
Jun 14, 2019

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Jun 11, 2019

Description

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

Exposed the cgroups.collect exceptions to distinguish difference between incorrect configuration and 0 value.
@vrdmr vrdmr requested review from narrieta and pgombar June 11, 2019 21:36
@vrdmr vrdmr changed the base branch from develop to cgroups June 11, 2019 21:36
@vrdmr vrdmr force-pushed the vameru/remove-empty-perf-metrics branch from 9a62376 to 52a5994 Compare June 11, 2019 23:16
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #1553 into cgroups will increase coverage by 0.04%.
The diff coverage is 76.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           cgroups    #1553      +/-   ##
===========================================
+ Coverage    63.18%   63.22%   +0.04%     
===========================================
  Files           78       78              
  Lines        10989    11029      +40     
  Branches      1543     1550       +7     
===========================================
+ Hits          6943     6973      +30     
- Misses        3710     3718       +8     
- Partials       336      338       +2
Impacted Files Coverage Δ
azurelinuxagent/common/osutil/default.py 55.55% <0%> (-0.07%) ⬇️
azurelinuxagent/common/event.py 82.69% <100%> (ø) ⬆️
azurelinuxagent/common/exception.py 91.35% <100%> (-0.21%) ⬇️
azurelinuxagent/common/logger.py 88.59% <100%> (+1.18%) ⬆️
azurelinuxagent/common/cgroup.py 69.64% <55%> (-1.79%) ⬇️
azurelinuxagent/common/cgroupstelemetry.py 93.7% <76.92%> (-3.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12a03a...338adc0. Read the comment docs.

azurelinuxagent/common/cgroup.py Outdated Show resolved Hide resolved
azurelinuxagent/common/cgroup.py Outdated Show resolved Hide resolved
azurelinuxagent/common/cgroup.py Outdated Show resolved Hide resolved
azurelinuxagent/common/cgroupstelemetry.py Outdated Show resolved Hide resolved
azurelinuxagent/common/logger.py Outdated Show resolved Hide resolved
azurelinuxagent/common/osutil/default.py Outdated Show resolved Hide resolved
Copy link
Contributor

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be LGTM after refactoring the periodic_* functions and adding more info to log messages, as Norberto commented.

@vrdmr vrdmr force-pushed the vameru/remove-empty-perf-metrics branch from 5e40f6b to aae9fc9 Compare June 13, 2019 17:55
Copy link
Contributor

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@vrdmr vrdmr merged commit ab9cffe into Azure:cgroups Jun 14, 2019
@vrdmr vrdmr deleted the vameru/remove-empty-perf-metrics branch June 14, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants