-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve systemd tests and reset stdout/stderr #1563
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1563 +/- ##
===========================================
- Coverage 63.38% 63.38% -0.01%
===========================================
Files 78 78
Lines 11056 11057 +1
Branches 1559 1559
===========================================
Hits 7008 7008
- Misses 3709 3710 +1
Partials 339 339
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #1563 +/- ##
===========================================
- Coverage 63.38% 63.38% -0.01%
===========================================
Files 78 78
Lines 11056 11057 +1
Branches 1559 1559
===========================================
Hits 7008 7008
- Misses 3709 3710 +1
Partials 339 339
Continue to review full report at Codecov.
|
We might need to add new tests in test_extension.py, with an implementation in |
I agree, but this PR is contained to improving tests around systemd-run, not against the whole class. I can do that in a separate PR since it will be a lot of changes. The issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Address leftover comments from #1556:
azurelinuxagent.utils.processutil.read_output
azurelinuxagent.common.event.add_event
Description
Issue #
PR information
Quality of Code and Contribution Guidelines
This change is