Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing the erroneous download events to send only periodically #1567

Merged
merged 3 commits into from
Jun 28, 2019

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Jun 27, 2019

Description

Also, activating the skipped unittests.

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #1567 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1567      +/-   ##
==========================================
+ Coverage    63.37%   63.4%   +0.03%     
==========================================
  Files           78      78              
  Lines        11058   11063       +5     
  Branches      1559    1561       +2     
==========================================
+ Hits          7008    7015       +7     
+ Misses        3711    3709       -2     
  Partials       339     339
Impacted Files Coverage Δ
azurelinuxagent/ga/exthandlers.py 81.61% <100%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b581fdc...896f49e. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #1567 into develop will increase coverage by 0.05%.
The diff coverage is 84.21%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1567      +/-   ##
===========================================
+ Coverage    63.37%   63.43%   +0.05%     
===========================================
  Files           78       78              
  Lines        11058    11070      +12     
  Branches      1559     1562       +3     
===========================================
+ Hits          7008     7022      +14     
+ Misses        3711     3709       -2     
  Partials       339      339
Impacted Files Coverage Δ
azurelinuxagent/common/protocol/wire.py 69.2% <50%> (ø) ⬆️
azurelinuxagent/ga/exthandlers.py 81.75% <88.23%> (+0.46%) ⬆️
azurelinuxagent/common/cgroupapi.py 62.5% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b581fdc...f77ccfe. Read the comment docs.

Copy link
Contributor

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrdmr vrdmr merged commit fa41f58 into Azure:develop Jun 28, 2019
@vrdmr vrdmr deleted the vameru/make-unittests-active branch June 28, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants