Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting the poll times when the metric is cleared. #1583

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Jul 16, 2019

Description

Currently, the poll times are not reset, causing the stale first-poll time to show up in the reporting period. This change is to reset the poll periods.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@vrdmr vrdmr requested review from narrieta and pgombar July 16, 2019 01:01
@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@2ffb7dc). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1583   +/-   ##
==========================================
  Coverage           ?   64.55%           
==========================================
  Files              ?       78           
  Lines              ?    11103           
  Branches           ?     1569           
==========================================
  Hits               ?     7168           
  Misses             ?     3595           
  Partials           ?      340
Impacted Files Coverage Δ
azurelinuxagent/common/cgroupstelemetry.py 94.02% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ffb7dc...ec6b731. Read the comment docs.

@vrdmr vrdmr merged commit 512c66c into Azure:develop Jul 16, 2019
@vrdmr vrdmr deleted the vameru/poll-time-reset branch July 16, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants