Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removing distro info from logs #1681

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

pgombar
Copy link
Contributor

@pgombar pgombar commented Oct 24, 2019

Description

This line got removed in #1635 by mistake, adding it back since it's useful to have in the log.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #1681 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1681      +/-   ##
===========================================
+ Coverage    67.34%   67.35%   +<.01%     
===========================================
  Files           80       80              
  Lines        11433    11434       +1     
  Branches      1605     1605              
===========================================
+ Hits          7700     7701       +1     
  Misses        3393     3393              
  Partials       340      340
Impacted Files Coverage Δ
azurelinuxagent/daemon/main.py 73.19% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e013ce...5a40034. Read the comment docs.

Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgombar pgombar merged commit 081604b into Azure:develop Oct 24, 2019
@pgombar pgombar deleted the add_distro_info_log branch November 6, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants