Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log error on retryable mount attempt #1685

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

trstringer
Copy link
Contributor

@trstringer trstringer commented Oct 26, 2019

Description

If there is a retryable mount error then we shouldn't be logging the error. The only time mount should log an error is on the final attempt at mounting, where we would consider it a failure event on a non-zero exit status.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@trstringer
Copy link
Contributor Author

trstringer commented Oct 27, 2019

Adding @anhvoms for visibility.

@narrieta narrieta merged commit 8c108ec into Azure:develop Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants