Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more exact when detecting IMDS service health #1695

Merged
merged 5 commits into from Nov 6, 2019
Merged

Be more exact when detecting IMDS service health #1695

merged 5 commits into from Nov 6, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 4, 2019

Description

This change removes the fault from IMDS when connection errors and throttling occurs.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@ghost ghost requested review from larohra, narrieta, pgombar and vrdmr as code owners November 4, 2019 21:46
@ghost ghost assigned narrieta Nov 4, 2019
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@b82a31b). Click here to learn what that means.
The diff coverage is 95.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1695   +/-   ##
==========================================
  Coverage           ?   67.62%           
==========================================
  Files              ?       80           
  Lines              ?    11498           
  Branches           ?     1613           
==========================================
  Hits               ?     7775           
  Misses             ?     3381           
  Partials           ?      342
Impacted Files Coverage Δ
azurelinuxagent/common/protocol/imds.py 95.39% <95.34%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b82a31b...9cb7363. Read the comment docs.

vrdmr
vrdmr previously approved these changes Nov 5, 2019
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

azurelinuxagent/common/protocol/imds.py Outdated Show resolved Hide resolved
azurelinuxagent/common/protocol/imds.py Outdated Show resolved Hide resolved
azurelinuxagent/common/protocol/imds.py Outdated Show resolved Hide resolved
tests/protocol/test_imds.py Outdated Show resolved Hide resolved
@narrieta
Copy link
Member

narrieta commented Nov 5, 2019

LGTM; will merge once the other comments are addressed.

@vrdmr vrdmr added the v2.2.45 label Nov 5, 2019
pgombar
pgombar previously approved these changes Nov 6, 2019
Copy link
Contributor

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments.

azurelinuxagent/common/protocol/imds.py Show resolved Hide resolved
azurelinuxagent/common/protocol/imds.py Outdated Show resolved Hide resolved
@ghost ghost dismissed stale reviews from pgombar and vrdmr via fc8e7f8 November 6, 2019 15:47
@pgombar pgombar self-requested a review November 6, 2019 17:49
pgombar
pgombar previously approved these changes Nov 6, 2019
vrdmr
vrdmr previously approved these changes Nov 6, 2019
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor. LGTM.

azurelinuxagent/common/protocol/imds.py Show resolved Hide resolved
azurelinuxagent/common/protocol/imds.py Show resolved Hide resolved
narrieta
narrieta previously approved these changes Nov 6, 2019
@ghost ghost dismissed stale reviews from narrieta, vrdmr, and pgombar via 9cb7363 November 6, 2019 19:46
@vrdmr vrdmr merged commit fca6005 into Azure:develop Nov 6, 2019
@ghost ghost deleted the imds_health_report branch November 8, 2019 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants