Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve telemetry event for OS info #1698

Merged
merged 2 commits into from
Nov 6, 2019

Conversation

pgombar
Copy link
Contributor

@pgombar pgombar commented Nov 5, 2019

Description

Make telemetry event introduced in PR #1635 a permanent one and move the event creation later, after monitoring handler has been instantiated, since otherwise the ContainerId might not be initialized when sending the event.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@b82a31b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1698   +/-   ##
==========================================
  Coverage           ?   67.62%           
==========================================
  Files              ?       80           
  Lines              ?    11481           
  Branches           ?     1608           
==========================================
  Hits               ?     7764           
  Misses             ?     3375           
  Partials           ?      342
Impacted Files Coverage Δ
azurelinuxagent/ga/update.py 88.42% <100%> (ø)
azurelinuxagent/common/event.py 83.76% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b82a31b...32649ff. Read the comment docs.

Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgombar pgombar merged commit ea090b4 into Azure:develop Nov 6, 2019
@pgombar pgombar deleted the add_os_info_telemetry branch November 6, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants