Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize agent version in test for telemetry event #1701

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

pgombar
Copy link
Contributor

@pgombar pgombar commented Nov 7, 2019

Description

When the agent version is bumped up, the unit test fails because the agent version was hard-coded instead of parametric.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@pgombar pgombar merged commit 823ef35 into Azure:develop Nov 7, 2019
@pgombar pgombar deleted the fix_version_in_unit_test branch November 7, 2019 00:28
@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@df98f00). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1701   +/-   ##
==========================================
  Coverage           ?   67.65%           
==========================================
  Files              ?       80           
  Lines              ?    11515           
  Branches           ?     1616           
==========================================
  Hits               ?     7790           
  Misses             ?     3383           
  Partials           ?      342

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df98f00...c9f37ab. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants