Do not update goal state when refreshing the host plugin #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narrieta
commented
Dec 21, 2019
Codecov Report
@@ Coverage Diff @@
## develop #1741 +/- ##
===========================================
+ Coverage 68.39% 68.44% +0.04%
===========================================
Files 81 81
Lines 11741 11734 -7
Branches 1648 1645 -3
===========================================
+ Hits 8030 8031 +1
+ Misses 3369 3362 -7
+ Partials 342 341 -1
Continue to review full report at Codecov.
|
narrieta
commented
Dec 21, 2019
narrieta
commented
Dec 21, 2019
narrieta
commented
Dec 21, 2019
narrieta
commented
Dec 21, 2019
narrieta
commented
Dec 21, 2019
narrieta
commented
Dec 21, 2019
narrieta
commented
Dec 21, 2019
tests/protocol/mockwiredata.py
Outdated
| # For the use of "(?<=" "(?=" see 7.2.1 in https://docs.python.org/3.1/library/re.html | ||
| # For the use of "\g<1>" see backreferences in https://docs.python.org/3.1/library/re.html#re.sub | ||
| # | ||
| # Note that these regular expressions are not enough to _parse all valid XML documents (e.g. they do |
narrieta
commented
Dec 21, 2019
narrieta
commented
Dec 26, 2019
tests/protocol/mockwiredata.py
Outdated
| # | ||
| # Note that these regular expressions are not enough to _parse all valid XML documents (e.g. they do | ||
| # not account for metacharacters like < or > in the values) but they are good enough for the test | ||
| # data. There are some basic checks, but the functions could could not match valid XML or produce |
There was a problem hiding this comment.
typo: "could could not match" -> "may not match"
larohra
previously approved these changes
Dec 26, 2019
vrdmr
approved these changes
Dec 26, 2019
rjschwei
pushed a commit
to rjschwei/WALinuxAgent
that referenced
this pull request
Mar 24, 2020
* Do not update goal state when refreshing the host plugin * Fixing typos and undoing bad rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are updating the goal state too frequently and that is part of the reason different components are getting out of sync. One of the reasons we were forcing updates of the goal state was to retry calls to the host plugin when the container id or the role config change. In this case updating the full goal state is not needed and it can actually introduce consistency issues.
The main change in this PR is to define an API specifically to update the host plugin without changing the goal state.
Other small changes are minor cleanup of the update goal state in the metadata protocol and the parse code of the goal state; I'll add comments in the PR to explain those changes.
This change is