Share protocol instance between main loop and remote access #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1749 +/- ##
===========================================
+ Coverage 68.51% 68.56% +0.05%
===========================================
Files 81 82 +1
Lines 11737 11740 +3
Branches 1645 1646 +1
===========================================
+ Hits 8042 8050 +8
+ Misses 3353 3346 -7
- Partials 342 344 +2
Continue to review full report at Codecov.
|
larohra
reviewed
Jan 10, 2020
| import azurelinuxagent.ga.update as update | ||
|
|
||
|
|
||
| class TestImportHandler(AgentTestCase): |
There was a problem hiding this comment.
Just curious what was this file for?
There was a problem hiding this comment.
Beats me :) I see no use for it and needs to be update when changing those methods. Since it provides no useful tests I decided to delete it instead of keeping it up to date
pgombar
previously approved these changes
Jan 10, 2020
pgombar
approved these changes
Jan 10, 2020
larohra
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple refactoring: passing the protocol instance from the main loop to remote access.
This change is