Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic HeartBeat to be logged to the file #1755

Merged
merged 8 commits into from
Jan 22, 2020

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Jan 14, 2020

Description

Adding Heartbeat logs to file. It logs every 12 hours currently, and helps in debugging.

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@5335ef4). Click here to learn what that means.
The diff coverage is 76.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1755   +/-   ##
==========================================
  Coverage           ?   69.18%           
==========================================
  Files              ?       82           
  Lines              ?    11720           
  Branches           ?     1644           
==========================================
  Hits               ?     8108           
  Misses             ?     3261           
  Partials           ?      351
Impacted Files Coverage Δ
azurelinuxagent/daemon/main.py 73.68% <0%> (ø)
azurelinuxagent/common/protocol/util.py 83.41% <0%> (ø)
azurelinuxagent/ga/monitor.py 93.91% <100%> (ø)
azurelinuxagent/ga/remoteaccess.py 88.88% <100%> (ø)
azurelinuxagent/ga/env.py 72.89% <100%> (ø)
azurelinuxagent/ga/update.py 88.76% <100%> (ø)
azurelinuxagent/common/protocol/hostplugin.py 84.15% <100%> (ø)
azurelinuxagent/common/rdma.py 16.84% <33.33%> (ø)
azurelinuxagent/common/protocol/wire.py 77.83% <72.94%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5335ef4...c11f903. Read the comment docs.

Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

azurelinuxagent/ga/monitor.py Outdated Show resolved Hide resolved
azurelinuxagent/ga/monitor.py Outdated Show resolved Hide resolved
@vrdmr vrdmr added this to the v2.2.47 milestone Jan 15, 2020
pgombar
pgombar previously approved these changes Jan 17, 2020
azurelinuxagent/ga/update.py Outdated Show resolved Hide resolved
@vrdmr vrdmr merged commit 7692acd into Azure:develop Jan 22, 2020
@vrdmr vrdmr deleted the vameru/heartbeat-logging branch January 30, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants