Do not update goal state from main loop in monitor thread #1767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monitor thread and the extension handler thread may try to update the certificates from the goal state concurrently, which can produce sporadic failures.
The main loop in monitor actually does not need to update the full goal state; the only data it needs are the container id and role config name to keep the host ga plugin up to date (to send the plugin's hearbeat).
There is a small chance of a race condition during initialization: MonitorHandler.init_protocols calls update_goal_state. I will address that issue on a separate PR.
Verified the fix manually using the debugger on a live VM.
This change is