Monitor thread errors #1770
Merged
Monitor thread errors #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrdmr
approved these changes
Jan 31, 2020
|
|
||
| if metrics: | ||
| for metric in metrics: | ||
| report_metric(metric.category, metric.counter, metric.instance, metric.value) | ||
| except Exception as e: | ||
| logger.warn("Could not poll all the tracked telemetry due to {0}", ustr(e)) | ||
|
|
||
| self.last_cgroup_polling_telemetry = datetime.datetime.utcnow() |
Codecov Report
@@ Coverage Diff @@
## develop #1770 +/- ##
==========================================
Coverage ? 68.67%
==========================================
Files ? 82
Lines ? 11737
Branches ? 1645
==========================================
Hits ? 8060
Misses ? 3326
Partials ? 351Continue to review full report at Codecov.
|
pgombar
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to handle exceptions in the monitor thread main loop.
Minor refactoring of the functions called by the main loop to ensure consistency on how they handle exceptions. I decided to leave log_altered_network_configuration alone for now (it is setup as a high-priority operation).
Tested the refactoring changes using the debugger on a live VM.
This change is