Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed is_snappy function #1774

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Removed is_snappy function #1774

merged 1 commit into from
Feb 11, 2020

Conversation

larohra
Copy link
Contributor

@larohra larohra commented Feb 8, 2020

Removed is_snappy function from version.py as Snappy Ubuntu core has its own /etc/os-release file now which is recognised by python's platform.dist() that we use to determine the OS of a VM

Description

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

Removed is_snappy function from version.py as Snappy Ubuntu core has its own /etc/os-release file now which is recognised by python's platform.dist() that we use to determine the OS of a VM
@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #1774 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1774      +/-   ##
===========================================
+ Coverage    68.66%   68.69%   +0.02%     
===========================================
  Files           82       82              
  Lines        11737    11729       -8     
  Branches      1645     1642       -3     
===========================================
- Hits          8059     8057       -2     
+ Misses        3326     3322       -4     
+ Partials       352      350       -2
Impacted Files Coverage Δ
azurelinuxagent/common/version.py 71.73% <ø> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd531d6...5cba17b. Read the comment docs.

@larohra larohra merged commit 510b696 into develop Feb 11, 2020
@larohra larohra deleted the larohra-patch-1 branch February 11, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants