Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging for version mismatch #1895

Merged
merged 7 commits into from
May 29, 2020
Merged

Add logging for version mismatch #1895

merged 7 commits into from
May 29, 2020

Conversation

larohra
Copy link
Contributor

@larohra larohra commented May 26, 2020

Description

This PR is for reporting an event incase the version and version dont match.
This PR also include a new class called AgentGlobals which should be used for all globals being used in the agent.

This is a repair item being tracked by - https://msazure.visualstudio.com/One/_workitems/edit/5813935

Issue #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented May 26, 2020 •
edited
Loading

Codecov Report

Merging #1895 into develop will increase coverage by 0.03%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1895      +/-   ##
===========================================
+ Coverage    69.59%   69.62%   +0.03%     
===========================================
  Files           84       85       +1     
  Lines        11704    11723      +19     
  Branches      1627     1631       +4     
===========================================
+ Hits          8145     8162      +17     
- Misses        3213     3214       +1     
- Partials       346      347       +1
Impacted Files Coverage Δ
azurelinuxagent/common/protocol/goal_state.py 93.79% <87.50%> (-0.50%) ⬇️
azurelinuxagent/common/AgentGlobals.py 100.00% <100.00%> (ø)
azurelinuxagent/common/event.py 86.34% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcbe81b...732cbe0. Read the comment docs.

@larohra
Copy link
Contributor Author

larohra commented May 27, 2020

DCR run - https://tuxgold.corp.microsoft.com/job/AzLinux/job/DungeonCrawler/job/DungeonCrawler.larohra2/473/artifact/results/

pgombar
pgombar approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment

azurelinuxagent/common/protocol/goal_state.py Show resolved Hide resolved
@larohra larohra merged commit ca6a53d into Azure:develop May 29, 2020
@larohra larohra deleted the add-logging-for-version-mismatch branch May 29, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgombar pgombar pgombar approved these changes

@narrieta narrieta narrieta approved these changes

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larohra @narrieta @pgombar