-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Provisioning.MonitorHostName for Ubuntu #1934
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1934 +/- ##
============================================
+ Coverage 26.40% 69.53% +43.13%
============================================
Files 93 85 -8
Lines 12764 11929 -835
Branches 1800 1673 -127
============================================
+ Hits 3370 8295 +4925
+ Misses 9350 3263 -6087
- Partials 44 371 +327
Continue to review full report at Codecov.
|
@trstringer please preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you remove the change from the default waagent.conf for Ubuntu, the PR looks good and I'll approve it then.
Running end-to-end automation. |
Automation OK: https://tuxgold.corp.microsoft.com/job/AzLinux/job/DungeonCrawler/job/DungeonCrawler.pagombar/999/ @narrieta could you take a look? |
Updated to latest develop changes, running automation again: https://tuxgold.corp.microsoft.com/job/AzLinux/job/DungeonCrawler/job/DungeonCrawler.pagombar/1001/ |
@taoyama Thank you for the update. Looks good. I will run automation and merge the PR when it completes. |
automation ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taoyama - thank you!
Description
This patch fix the Issue #1546
PR information
Quality of Code and Contribution Guidelines