Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Provisioning.MonitorHostName for Ubuntu #1934

Merged
merged 9 commits into from
Dec 14, 2020
Merged

Conversation

taoyama
Copy link
Contributor

@taoyama taoyama commented Jul 3, 2020

Description

This patch fix the Issue #1546

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #1934 (dd1ce7c) into develop (86676fa) will increase coverage by 43.13%.
The diff coverage is 9.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #1934       +/-   ##
============================================
+ Coverage    26.40%   69.53%   +43.13%     
============================================
  Files           93       85        -8     
  Lines        12764    11929      -835     
  Branches      1800     1673      -127     
============================================
+ Hits          3370     8295     +4925     
+ Misses        9350     3263     -6087     
- Partials        44      371      +327     
Impacted Files Coverage Δ
azurelinuxagent/common/osutil/ubuntu.py 60.71% <9.09%> (+8.27%) ⬆️
azurelinuxagent/common/future.py 39.28% <0.00%> (-0.06%) ⬇️
azurelinuxagent/common/rdma.py 19.85% <0.00%> (ø)
azurelinuxagent/pa/deprovision/clearlinux.py 62.50% <0.00%> (ø)
azurelinuxagent/common/logcollector_manifests.py
azurelinuxagent/ga/send_telemetry_events.py
azurelinuxagent/pa/provision/cloudinitdetect.py
azurelinuxagent/ga/collect_logs.py
azurelinuxagent/common/interfaces.py
azurelinuxagent/daemon/__init__.py
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e9b985...fa15b34. Read the comment docs.

@taoyama taoyama changed the title Fix #1546 Enabel Provisioning.MonitorHostName for Ubuntu Jul 10, 2020
@taoyama taoyama changed the title Enabel Provisioning.MonitorHostName for Ubuntu Enable Provisioning.MonitorHostName for Ubuntu Jul 10, 2020
@pgombar pgombar requested a review from trstringer July 16, 2020 21:15
azurelinuxagent/common/osutil/ubuntu.py Outdated Show resolved Hide resolved
config/ubuntu/waagent.conf Outdated Show resolved Hide resolved
@taoyama
Copy link
Contributor Author

taoyama commented Nov 16, 2020

@trstringer please preview

Copy link
Contributor

@trstringer trstringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the change from the default waagent.conf for Ubuntu, the PR looks good and I'll approve it then.

config/ubuntu/waagent.conf Outdated Show resolved Hide resolved
trstringer
trstringer previously approved these changes Nov 24, 2020
@pgombar
Copy link
Contributor

pgombar commented Nov 25, 2020

Running end-to-end automation.

@pgombar
Copy link
Contributor

pgombar commented Nov 30, 2020

Running end-to-end automation.

Automation OK: https://tuxgold.corp.microsoft.com/job/AzLinux/job/DungeonCrawler/job/DungeonCrawler.pagombar/999/

@narrieta could you take a look?

@pgombar
Copy link
Contributor

pgombar commented Dec 7, 2020

Updated to latest develop changes, running automation again: https://tuxgold.corp.microsoft.com/job/AzLinux/job/DungeonCrawler/job/DungeonCrawler.pagombar/1001/

pgombar
pgombar previously approved these changes Dec 7, 2020
@narrieta
Copy link
Member

@taoyama Thank you for the update. Looks good. I will run automation and merge the PR when it completes.

@narrieta
Copy link
Member

automation ok

Copy link
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taoyama - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants