Use run_command for ip route #1958
Conversation
narrieta
requested review from
kevinclark19a,
larohra,
pgombar and
ZhidongPeng
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #1958 +/- ##
===========================================
- Coverage 69.67% 69.59% -0.08%
===========================================
Files 85 85
Lines 11985 11998 +13
Branches 1677 1677
===========================================
Hits 8350 8350
- Misses 3263 3276 +13
Partials 372 372
Continue to review full report at Codecov.
|
| chk_err=False) | ||
| try: | ||
| route_cmd = ["ip", "route", "add", "255.255.255.255", "dev", ifname] | ||
| return shellutil.run_command(route_cmd) |
There was a problem hiding this comment.
Why is this method even returning? The callers do nothing with the return value.
There was a problem hiding this comment.
yes, i noticed that but won't fix it now. there are several implementations of the method
There was a problem hiding this comment.
It's an easy change since none of the callers do anything with the return value, but I won't block your PR for it, up to you.
| return shellutil.run(cmd, chk_err=False) | ||
| try: | ||
| cmd = ["ip", "route", "add", net, "via", gateway] | ||
| return shellutil.run_command(cmd) |
There was a problem hiding this comment.
Same comment here; return is not used anywhere.
ip route was using run/run_get_output