-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Travis special checks for distro and remove useless cgroup tests #1959
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1959 +/- ##
========================================
Coverage 69.67% 69.67%
========================================
Files 85 85
Lines 11985 11985
Branches 1677 1677
========================================
Hits 8350 8350
Misses 3263 3263
Partials 372 372 Continue to review full report at Codecov.
|
return ret | ||
|
||
|
||
def is_trusty_in_travis(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't used anywhere.
return Ubuntu16OSUtil() | ||
|
||
|
||
def mock_get_osutil(*args): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole method is obsolete since there is no need to do custom checks in Travis anymore.
8d89e0e
Description
We had special checks for distro resolution in Travis since Ubuntu 14.04 (trusty) was resolving to something else (debian/stretch). Unit tests started failing since Travis updated their OS environment variables and also fixed the distro resolution, so our custom solution is not needed anymore.
os.environ['_system_name']
andos.environ['_system_version']
are deprecated, now it's just'TRAVIS_DIST': 'xenial'
PR information
Quality of Code and Contribution Guidelines