Fixed delays for HTTP retries rather than exponential delays #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larohra
requested review from
kevinclark19a,
narrieta,
pgombar and
ZhidongPeng
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #1967 +/- ##
===========================================
- Coverage 69.60% 69.59% -0.02%
===========================================
Files 85 85
Lines 11998 11993 -5
Branches 1677 1676 -1
===========================================
- Hits 8351 8346 -5
Misses 3273 3273
Partials 374 374
Continue to review full report at Codecov.
|
kevinclark19a
previously approved these changes
Jul 30, 2020
narrieta
reviewed
Jul 31, 2020
tests/utils/test_rest_util.py
Outdated
| restutil.http_get("http://foo.bar", retry_delay=retry_delay_in_sec, max_retry=max_retry) | ||
| duration = datetime.utcnow() - start_time | ||
|
|
||
| self.assertEqual(max_retry, mock_resp.call_count, "Did not Retry the required amount of time") |
There was a problem hiding this comment.
should be "times" in "Did not Retry the required amount of times"
narrieta
approved these changes
Jul 31, 2020
kevinclark19a
approved these changes
Jul 31, 2020
6 tasks
pgombar
added a commit
to pgombar/WALinuxAgent
that referenced
this pull request
Nov 5, 2020
…zure#1967)" This reverts commit 0991c3a.
6 tasks
pgombar
added a commit
that referenced
this pull request
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue where we can see upto 5mins of provisioning delay due to exponential delays in the restutil logic. Now, we will only have sequential delays. Changed the defaults to be at par with the Windows Guest Agent.
Issue #
PR information
Quality of Code and Contribution Guidelines