Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled linter for setup.py and makepkg.py. #1975

Merged
merged 5 commits into from
Aug 19, 2020

Conversation

kevinclark19a
Copy link
Contributor

@kevinclark19a kevinclark19a commented Aug 11, 2020

Description

1st of 7 PRs enabling linter in Travis.

Error Codes can be found here: http://pylint.pycqa.org/en/latest/technical_reference/features.html


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #1975 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1975   +/-   ##
========================================
  Coverage    71.15%   71.15%           
========================================
  Files           86       86           
  Lines        12285    12285           
  Branches      1729     1729           
========================================
  Hits          8741     8741           
  Misses        3159     3159           
  Partials       385      385           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fa5bf4...61282c8. Read the comment docs.

Copy link
Contributor

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not approving before the pylintrc files are updated.

narrieta
narrieta previously approved these changes Aug 19, 2020
@kevinclark19a kevinclark19a merged commit de5302b into Azure:develop Aug 19, 2020
@kevinclark19a kevinclark19a deleted the LinterEnabledSetupMakePkg branch January 6, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants