Enabled linter for azurelinuxagent.ga. #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinclark19a
requested review from
larohra,
narrieta,
pgombar and
ZhidongPeng
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #1980 +/- ##
========================================
Coverage 71.15% 71.15%
========================================
Files 86 86
Lines 12285 12285
Branches 1729 1729
========================================
Hits 8741 8741
Misses 3159 3159
Partials 385 385
Continue to review full report at Codecov.
|
pgombar
approved these changes
Aug 17, 2020
narrieta
reviewed
Aug 19, 2020
| @@ -158,8 +158,8 @@ def _capture_extension_events(self, handler_name, handler_event_dir_path, events | |||
| event_file_size = os.stat(event_file_path).st_size | |||
| if event_file_size > self._EXTENSION_EVENT_FILE_MAX_SIZE: | |||
| msg = "Skipping file: {0} as its size is {1:.2f} Mb > Max size allowed {2:.1f} Mb".format( | |||
| event_file_path, convert_to_mb(event_file_size), | |||
| convert_to_mb(self._EXTENSION_EVENT_FILE_MAX_SIZE)) | |||
| event_file_path, convert_to_mb(event_file_size), #pylint: disable=C0330 | |||
There was a problem hiding this comment.
I guess the missing space in "#pylint" doesn't matter?
narrieta
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
6th of 7 PRs enabling linter in Travis.
Error Codes can be found here: http://pylint.pycqa.org/en/latest/technical_reference/features.html
PR information
Quality of Code and Contribution Guidelines