Fix arguments-differ<W0221> linter errors.
#1993
Conversation
kevinclark19a
requested review from
larohra,
narrieta,
pgombar and
ZhidongPeng
as code owners
| @@ -34,7 +34,7 @@ def is_dhcp_enabled(self): | |||
| def get_dhcp_pid(self): | |||
| return self._get_dhcp_pid(["pidof", "dhcpcd"]) | |||
|
|
|||
| def restart_if(self, ifname): # pylint: disable=W0221 | |||
| def restart_if(self, ifname, unused_retries=None, unused_wait=None): | |||
There was a problem hiding this comment.
we should keep the parameter names consistent, too, in case somebody ever does "restart_if(..., retries=...)
| # the original (and, by forwarding the kwargs to the original, will reject any | ||
| # option _not_ accepted by the original). Additionally, this method allows us | ||
| # to keep the defaults for mount_dvd in one place (the original function) instead | ||
| # of having to duplicate it here as well. |
There was a problem hiding this comment.
But with this signature this function will accept arguments the base function doesn't
There was a problem hiding this comment.
Sort of; this function basically immediately passes the kwargs to its super, which would then error out on invalid input.
I realize that that doesn't completely localize the error to this function, though; I felt like this was better than repeating the defaults here as well, and having to keep both up to date. Maybe this isn't the case, though.
kevinclark19a
force-pushed
the
LinterArgumentsDiffer
branch
from
44f645e
to
45f3e99
Compare
kevinclark19a
dismissed stale reviews from narrieta and pgombar
via
7bfbf3f
| @@ -34,7 +34,7 @@ def is_dhcp_enabled(self): | |||
| def get_dhcp_pid(self): | |||
| return self._get_dhcp_pid(["pidof", "dhcpcd"]) | |||
|
|
|||
| def restart_if(self, ifname): # pylint: disable=W0221 | |||
| def restart_if(self, ifname, retries=None, wait=None): | |||
There was a problem hiding this comment.
I'm surprised pylint is not complaining about unused variables now lol
There was a problem hiding this comment.
I was also confused with this, lol. My understanding is that pylint is smart enough to realize that these parameters are used in the base classes' method, that this method is overriding.
Description
PR information
Quality of Code and Contribution Guidelines