Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test: increase timeout and relax assertion #1994

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

pgombar
Copy link
Contributor

@pgombar pgombar commented Aug 26, 2020

Description

On some rare occasions, the calls to mock_sleep are not exact to what this test is expecting. Relaxing the assertions and increasing the mocked timeout to make the test more robust.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@pgombar pgombar merged commit af75b40 into Azure:develop Aug 27, 2020
@pgombar pgombar deleted the flaky_test branch August 27, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants