Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing linter errors: logging-format-interpolation<W1202>. #2000

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Fixing linter errors: logging-format-interpolation<W1202>. #2000

merged 1 commit into from
Sep 9, 2020

Conversation

kevinclark19a
Copy link
Contributor

Description

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

pgombar
pgombar reviewed Sep 8, 2020
View reviewed changes
azurelinuxagent/common/logcollector.py
_LOGGER.info("Using {0} as $LIB_DIR".format(_AGENT_LIB_DIR)) # pylint: disable=W1202
_LOGGER.info("Using {0} as $LOG_DIR".format(_EXTENSION_LOG_DIR)) # pylint: disable=W1202
_LOGGER.info("Using {0} as $AGENT_LOG".format(_AGENT_LOG)) # pylint: disable=W1202
_LOGGER.info("Using %s as $LIB_DIR", _AGENT_LIB_DIR)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already cleaned up this file in my pending PR (#1987), sorry you did double work! But thanks for removing this error from the linter conf, I had not done that.

@kevinclark19a kevinclark19a merged commit 727cfe7 into Azure:develop Sep 9, 2020
@kevinclark19a kevinclark19a deleted the LinterLoggingFormat branch September 9, 2020 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgombar pgombar pgombar approved these changes

@larohra larohra larohra approved these changes

@narrieta narrieta Awaiting requested review from narrieta narrieta is a code owner

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinclark19a @pgombar @larohra