Fixing Linter errors: assignment-from-no-return<E1111> #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinclark19a
requested review from
larohra,
narrieta,
pgombar and
ZhidongPeng
as code owners
kevinclark19a
commented
Sep 4, 2020
| @@ -214,8 +214,7 @@ def remove_extension_cgroups(self, name): | |||
| Deletes the cgroup for the given extension | |||
| """ | |||
| def __impl(): | |||
| cgroups = self._cgroups_api.remove_extension_cgroups(name) # pylint: disable=E1111 | |||
| return cgroups | |||
| self._cgroups_api.remove_extension_cgroups(name) | |||
There was a problem hiding this comment.
We don't actually have to return here. _invoke_cgroup_operation only uses the operation parameter's return value as its return value. As we're ignoring said return value, providing one here doesn't do anything for us.
You can see this pattern above, on line 199 of this file, where _cgroups_api.create_extension_cgroups_root() also doesn't return anything.
pgombar
approved these changes
Sep 8, 2020
larohra
approved these changes
Sep 9, 2020
narrieta
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR information
Quality of Code and Contribution Guidelines