Remove enum _UpdateType and retry fetching goal state

[narrieta]

Removing enum _UpdateType simplifies the code a little bit.

The retry logic fetching goal state is not needed; the underlying http APIs aready handle retry.

[larohra]

Would it be useful to add a traceback here? Might be useful in figuring out what exactly failed when trying to fetch GS

[narrieta]

I thought you were adding the traceback to error messages? (one way to do that could be in the conversion to string of the base class for exceptions)

[narrieta]

btw - since this is just raising the exception, the traceback shouln't be added here, but in whoever handles the exception

[narrieta]

and another note:

one way to do that could be in the conversion to string of the base class for exceptions)

may lead to bad (but useful) formatting. An alternative would be to create a function in the logger to log an exception. That function could also add traceback for the inner exceptions.

[larohra]

I thought you were adding the traceback to error messages?

I was primarily talking about doing it on a case to case basis, but I like your idea better of adding it for every error.

An alternative would be to create a function in the logger to log an exception.

That would be useful for sure, maybe reuse the logger.error? But anyways not sure when I'll get time to work on that. For now do you wanna add the trace here until we have a better solution in place?

[narrieta]

The trace should not be added here, that should be done at the place where the exception is handled.

[larohra]

1 minor comment but else LGTM