Remove Serial Console Logging #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 24, 2020 19:35
kevinclark19a
requested review from
larohra,
narrieta,
pgombar and
ZhidongPeng
as code owners
narrieta
approved these changes
Sep 30, 2020
larohra
reviewed
Sep 30, 2020
| @@ -66,9 +66,6 @@ def __init__(self, verbose, conf_file_path=None): | |||
| level = logger.LogLevel.VERBOSE if verbose else logger.LogLevel.INFO | |||
| logger.add_logger_appender(logger.AppenderType.FILE, level, | |||
| path=conf.get_agent_log_file()) | |||
| if conf.get_logs_console(): | |||
There was a problem hiding this comment.
Did we get some communication out to EEE people? I think they are dependent on this
pgombar
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Agent output to the serial console can make it hard to use the console in debugging scenarios. This PR disables logging output to the serial console.
PR information
Quality of Code and Contribution Guidelines