Adding telemetry for logrotate #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinclark19a
requested review from
larohra,
narrieta,
pgombar and
ZhidongPeng
as code owners
pgombar
reviewed
Oct 20, 2020
azurelinuxagent/common/version.py
Outdated
| @@ -176,6 +176,20 @@ def get_lis_version(): | |||
| # imported in this module or we'd log this too. | |||
| return "Failed" | |||
|
|
|||
| def has_logrotate(): | |||
| """ | |||
There was a problem hiding this comment.
Remove empty quotes or add comment?
pgombar
previously approved these changes
Oct 20, 2020
larohra
reviewed
Oct 21, 2020
azurelinuxagent/common/version.py
Outdated
| except shellutil.CommandError: | ||
| # A non-zero return code means that logrotate isn't present on | ||
| # the system; --version shouldn't fail otherwise. | ||
| return "Absent" |
There was a problem hiding this comment.
Define constants for this and use it here (and in the get_lis_version function above)?
azurelinuxagent/common/version.py
Outdated
| # the system; --version shouldn't fail otherwise. | ||
| return "Absent" | ||
| except Exception: | ||
| return "Failed" |
narrieta
approved these changes
Oct 22, 2020
pgombar
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a line to the osinfo telemetry specifying whether or not the VM has logrotoate.
PR information
Quality of Code and Contribution Guidelines