-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the way the PA checks for cloud-init existence and status #2061
Change the way the PA checks for cloud-init existence and status #2061
Conversation
LGTM; running automation |
@narrieta, I fixed the unit tests. The reason they were passing on our local machines is because we didn't have cloud-init installed on the test host. Therefore the call to Now that the tests are passing, this PR should be ready for re-review. |
@trstringer thanks; running automation |
automation ok |
LGTM |
Thanks, all, for the reviews! @narrieta, let me know if there's anything else you need from me prior to merging. |
@trstringer Just waiting for the Travis run to complete. Travis has been extremely slow these days. It seems like your run is still queued. |
Description
This PR changes the way that the provisioning agent in walinuxagent determines if cloud-init is already acting as the provisioning agent. This uses unit/service status to make this determination, instead of reading processes. This should be a more reliable implementation to make the correct determination. And it also reuses existing logic in walinuxagent for this discovery.
PR information
Quality of Code and Contribution Guidelines