Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert unicode fix manually (#1937) #2070

Merged
merged 5 commits into from
Nov 5, 2020
Merged

Revert unicode fix manually (#1937) #2070

merged 5 commits into from
Nov 5, 2020

Conversation

pgombar
Copy link
Contributor

@pgombar pgombar commented Nov 5, 2020

Description

Manually revert PR #1937 for the upcoming release.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@pgombar pgombar mentioned this pull request Nov 5, 2020
Closed
6 tasks
@pgombar pgombar added this to the v2.2.53 milestone Nov 5, 2020
larohra
larohra previously approved these changes Nov 5, 2020
View reviewed changes
narrieta
narrieta previously approved these changes Nov 5, 2020
View reviewed changes
@pgombar pgombar dismissed stale reviews from narrieta and larohra via 37ed54c November 5, 2020 22:13
@pgombar pgombar merged commit 072933d into Azure:develop Nov 5, 2020
@pgombar pgombar deleted the revert-unicode-fix branch November 5, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narrieta narrieta narrieta approved these changes

@larohra larohra larohra approved these changes

@kevinclark19a kevinclark19a Awaiting requested review from kevinclark19a

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.53
Development

Successfully merging this pull request may close these issues.
3 participants
@pgombar @narrieta @larohra