Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chained-comparison and dangerous-default-value pylint warnings #2072

Merged
merged 6 commits into from
Nov 10, 2020
Merged

Fix chained-comparison and dangerous-default-value pylint warnings #2072

merged 6 commits into from
Nov 10, 2020

Conversation

pgombar
Copy link
Contributor

@pgombar pgombar commented Nov 6, 2020

Description

Fix two pylint warnings + some whitespace changes.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

narrieta
narrieta previously approved these changes Nov 6, 2020
View reviewed changes
larohra
larohra reviewed Nov 7, 2020
View reviewed changes
Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment else LGTM

azurelinuxagent/common/utils/restutil.py Outdated Show resolved Hide resolved
@pgombar pgombar merged commit ae20f71 into Azure:develop Nov 10, 2020
@pgombar pgombar deleted the fix_pylint_warnings branch November 10, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narrieta narrieta narrieta approved these changes

@larohra larohra larohra approved these changes

@kevinclark19a kevinclark19a Awaiting requested review from kevinclark19a

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgombar @narrieta @larohra