Add support for VMs with multiple IB devices #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longlimsft
requested review from
kevinclark19a,
larohra,
narrieta,
pgombar and
ZhidongPeng
as code owners
longlimsft
force-pushed
the
multi-ib5
branch
from
6524cb8
to
881ca2a
Compare
|
running automation |
|
automation ok |
narrieta
previously approved these changes
Dec 2, 2020
|
Hey @longlimsft, any update on the PR? Feel free to ping me if you need any clarification about any of my comments above! |
Newer HPC VM supports multiple Infiniband NICs. A new KVP format is introduced in KVP pool0 to pass multiple IPs from KVP daemon. The KVP is of format: (e.g passing two IPs to two IB) key name: IPoIB_Data value: NUMPAIRS:2|FFFFFFFFFFF1:172.16.0.1|FFFFFFFFFFF2:172.16.0.2 FFFFFFFFFFF1 and FFFFFFFFFFF2 are the MAC address for the IP over IB device. 172.16.0.1 and 172.16.0.2 are their respective IPs. If this key is not present in the KVP pool0, the Linux agent falls back to the old code path of provisioning a single IB device, thus maintaining compatiblity with older HPC VMs.
I have updated the pull request. Please take a look. |
larohra
reviewed
Dec 7, 2020
larohra
reviewed
Dec 7, 2020
narrieta
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer HPC VM supports multiple Infiniband NICs. A new KVP format is
introduced in KVP pool0 to pass multiple IPs from KVP daemon. The KVP
is of format: (e.g passing two IPs to two IB)
key name: IPoIB_Data
value: NUMPAIRS:2|FFFFFFFFFFF1:172.16.0.1|FFFFFFFFFFF2:172.16.0.2
FFFFFFFFFFF1 and FFFFFFFFFFF2 are the MAC address for the IP over IB device.
172.16.0.1 and 172.16.0.2 are their respective IPs.
If this key is not present in the KVP pool0, the Linux agent falls back to
the old code path of provisioning a single IB device, thus maintaining
compatiblity with older HPC VMs.
Description
Issue #
PR information
Quality of Code and Contribution Guidelines