Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary unit test #2153

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Remove unnecessary unit test #2153

merged 2 commits into from
Feb 1, 2021

Conversation

narrieta
Copy link
Member

The test was probably copy and pasted from the unit tests for the MonitorHandler; while it makes sense in that class, it doesn't here.

larohra
larohra previously approved these changes Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #2153 (28bf7dc) into develop (54b5756) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2153      +/-   ##
===========================================
- Coverage    70.52%   70.47%   -0.06%     
===========================================
  Files           95       95              
  Lines        13064    13064              
  Branches      1859     1859              
===========================================
- Hits          9214     9207       -7     
- Misses        3437     3441       +4     
- Partials       413      416       +3     
Impacted Files Coverage Δ
azurelinuxagent/ga/collect_telemetry_events.py 89.65% <0.00%> (-1.73%) ⬇️
azurelinuxagent/ga/collect_logs.py 87.80% <0.00%> (-1.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b5756...5a06f85. Read the comment docs.

@narrieta narrieta merged commit 04b59cb into Azure:develop Feb 1, 2021
@narrieta narrieta deleted the collect-logs branch February 2, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants