Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable custom service #2166

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Conversation

larohra
Copy link
Contributor

@larohra larohra commented Feb 8, 2021

Description

Do not setup agent network service if Os.EnableFirewall = False

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #2166 (c9a455d) into release-2.2.54 (84bbfbc) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.2.54    #2166      +/-   ##
==================================================
- Coverage           70.79%   70.77%   -0.03%     
==================================================
  Files                  96       96              
  Lines               13376    13379       +3     
  Branches             1877     1878       +1     
==================================================
- Hits                 9470     9469       -1     
- Misses               3493     3500       +7     
+ Partials              413      410       -3     
Impacted Files Coverage Δ
azurelinuxagent/ga/update.py 88.38% <100.00%> (-0.10%) ⬇️
azurelinuxagent/common/persist_firewall_rules.py 76.15% <0.00%> (-4.62%) ⬇️
azurelinuxagent/common/conf.py 78.92% <0.00%> (+0.49%) ⬆️
azurelinuxagent/ga/env.py 68.59% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84bbfbc...e6fb66f. Read the comment docs.

@larohra larohra merged commit 4372b36 into Azure:release-2.2.54 Feb 8, 2021
@larohra larohra deleted the disable-custom-service branch February 8, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants