Remove persistent firewall rules on deprovision #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larohra
requested review from
kevinclark19a,
narrieta and
ZhidongPeng
as code owners
larohra
commented
Mar 2, 2021
| @@ -94,6 +100,10 @@ def _is_firewall_service_running(): | |||
| return False | |||
|
|
|||
| def setup(self): | |||
| if not CGroupsApi.is_systemd(): | |||
| logger.warn("Did not detect Systemd, unable to set {0}".format(self._network_setup_service_name)) | |||
There was a problem hiding this comment.
logging as a warning instead of an error and moved one step up because checking firewall.service also requires systemd to be there
narrieta
approved these changes
Mar 3, 2021
kevinclark19a
approved these changes
Mar 3, 2021
larohra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #
PR information
Quality of Code and Contribution Guidelines