logger.warn when http fetch with exception happened. #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync from Official Repo
Pull from Azure/WALinuxAgent
Sync the latest code from Azure.
Sync the code from Azure:Develop
Pull from Azure/WALinuxAgent
ZhidongPeng
requested review from
kevinclark19a,
larohra and
narrieta
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2205 +/- ##
===========================================
+ Coverage 70.45% 70.47% +0.01%
===========================================
Files 96 96
Lines 13564 13573 +9
Branches 1915 1917 +2
===========================================
+ Hits 9557 9566 +9
Misses 3593 3593
Partials 414 414
Continue to review full report at Codecov.
|
kevinclark19a
approved these changes
Mar 12, 2021
kevinclark19a
previously approved these changes
Mar 12, 2021
narrieta
previously approved these changes
Mar 12, 2021
larohra
reviewed
Mar 15, 2021
ZhidongPeng
dismissed stale reviews from narrieta and kevinclark19a
via
3843052
larohra
previously approved these changes
Mar 15, 2021
kevinclark19a
previously approved these changes
Mar 15, 2021
kevinclark19a
approved these changes
Mar 18, 2021
larohra
reviewed
Mar 18, 2021
| @@ -172,6 +172,19 @@ def _parse_url(url): | |||
| secure = True | |||
| return o.hostname, o.port, secure, rel_uri | |||
|
|
|||
| def _trim_url_parameters(url): | |||
There was a problem hiding this comment.
Since this is a util function, it doesn't need to be a protected function. Can rename it to trim_url_parameters instead
larohra
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
logger.warn when http fetch with exception happened.
PR information
Quality of Code and Contribution Guidelines