Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report and cleanup handlers only if GS supported #2206

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

larohra
Copy link
Contributor

@larohra larohra commented Mar 16, 2021

Description

Report and cleanup extension handlers only if last GoalState was supported.
Incase it was unsupported, we should report the state of the extensions in the VM over what the new GS was asking us for and skip cleanup too.

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #2206 (14f2ed2) into develop (cc6ee4e) will increase coverage by 0.07%.
The diff coverage is 80.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2206      +/-   ##
===========================================
+ Coverage    70.43%   70.51%   +0.07%     
===========================================
  Files           96       96              
  Lines        13548    13564      +16     
  Branches      1910     1915       +5     
===========================================
+ Hits          9542     9564      +22     
+ Misses        3593     3590       -3     
+ Partials       413      410       -3     
Impacted Files Coverage Δ
azurelinuxagent/ga/exthandlers.py 86.81% <80.76%> (+0.09%) ⬆️
azurelinuxagent/ga/collect_telemetry_events.py 92.12% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6ee4e...14f2ed2. Read the comment docs.

narrieta
narrieta previously approved these changes Mar 17, 2021
Copy link
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; couple of comments

azurelinuxagent/ga/exthandlers.py Outdated Show resolved Hide resolved
azurelinuxagent/ga/exthandlers.py Show resolved Hide resolved
@larohra larohra merged commit 27158fe into Azure:develop Mar 17, 2021
@larohra larohra deleted the fix-unsupported-report branch March 17, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants