-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace firewall-setup unit file if changed #2236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; minor comments
|
||
# Remove custom service if exists to avoid problems with firewalld | ||
try: | ||
fileutil.rm_files(*[self.get_service_file_path(), os.path.join(conf.get_lib_dir(), self.BINARY_FILE_NAME)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this need a daemon-reload?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I verified manually, it didnt complain for it (I just verified it in the one distro where we know firewalld is there - RHEL 8+)
Codecov Report
@@ Coverage Diff @@
## release-2.3.0.0 #2236 +/- ##
===================================================
- Coverage 70.61% 70.60% -0.01%
===================================================
Files 96 96
Lines 13616 13642 +26
Branches 1928 1932 +4
===================================================
+ Hits 9615 9632 +17
- Misses 3584 3589 +5
- Partials 417 421 +4
Continue to review full report at Codecov.
|
Description
Issue #
PR information
Quality of Code and Contribution Guidelines