Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pylint warning: consider using with - CP: #2231 #2238

Merged
merged 5 commits into from
May 3, 2021

Conversation

larohra
Copy link
Contributor

@larohra larohra commented May 3, 2021

Description

Remove Pylint warning: consider using with - CP: #2231

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #2238 (d90bdf7) into release-2.3.0.0 (9906bc2) will decrease coverage by 0.00%.
The diff coverage is 43.75%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2.3.0.0    #2238      +/-   ##
===================================================
- Coverage            70.60%   70.59%   -0.01%     
===================================================
  Files                   96       96              
  Lines                13614    13615       +1     
  Branches              1927     1928       +1     
===================================================
  Hits                  9612     9612              
+ Misses                3586     3585       -1     
- Partials               416      418       +2     
Impacted Files Coverage Δ
azurelinuxagent/agent.py 54.14% <0.00%> (ø)
azurelinuxagent/daemon/scvmm.py 82.92% <0.00%> (ø)
azurelinuxagent/pa/rdma/ubuntu.py 14.28% <0.00%> (+0.36%) ⬆️
azurelinuxagent/common/utils/archive.py 83.67% <87.50%> (-0.36%) ⬇️
azurelinuxagent/ga/collect_telemetry_events.py 90.41% <0.00%> (-1.03%) ⬇️
azurelinuxagent/ga/exthandlers.py 86.84% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9906bc2...d90bdf7. Read the comment docs.

@larohra larohra merged commit 2ab6ce4 into Azure:release-2.3.0.0 May 3, 2021
@larohra larohra deleted the pylint-consider-using-with branch May 3, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants